[3.2] Add interpolation parameter to resize_to_po2() #44460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sure the commits that add the function and the doc update respectively could be unified. And thanks for your first contribution to Godot! |
|
@YeldhamDev Done! And it's my pleasure. 😃 |
clayjohn
previously requested changes
Dec 18, 2020
|
Should be good to go once you squash the commits together. For simple changes like this we prefer one commit. |
Image::resize_to_po2() now takes an optional p_interpolation parameter that it passes directly to resize() with default value INTERPOLATE_BILINEAR. GLES2: call resize_to_po2() with interpolate argument Call resize_to_po2() in GLES2 rasterizer storage with either INTERPOLATE_BILINEAR or INTERPOLATE_NEAREST depending on TEXTURE_FLAG_FILTER. This avoids filtering issues with non power of two pixel art textures. See godotengine#44379
|
@clayjohn Squashed. |
akien-mga
approved these changes
Dec 19, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional
p_interpolationparameter toImage::resize_to_po2()and call it in GLES2 rasterizer storage with eitherINTERPOLATE_BILINEARorINTERPOLATE_NEARESTdepending onTEXTURE_FLAG_FILTER.This is equivalent of #44445 that closes #44379 in 3.2.